blockstore: allow to pass a file to write in #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow the caller to control the file lifecycle and implement a cleaning strategy. An example would be: - open a file in a temporary folder - if the write suceed, close the file and move it to its final destination - on error, remove the file If the underlying filesystem support it, an anonymous file can be used instead: open then immediately delete, use the file descriptor to write. A crash before the end of the write process would release the used storage automatically.
Jorropo
approved these changes
Jul 28, 2022
rvagg
reviewed
Aug 1, 2022
|
aaaaactually, I probably should have asked for tests - @MichaelMure would you mind taking a look at the current test suite and see if you can extend one of them to control the file from outside rather than passing the path? |
rvagg
added a commit
that referenced
this pull request
Aug 12, 2022
This allow the caller to control the file lifecycle and implement a cleaning strategy. An example would be: - open a file in a temporary folder - if the write suceed, close the file and move it to its final destination - on error, remove the file If the underlying filesystem support it, an anonymous file can be used instead: open then immediately delete, use the file descriptor to write. A crash before the end of the write process would release the used storage automatically. Co-authored-by: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow the caller to control the file lifecycle and implement a cleaning strategy. An example would be:
If the underlying filesystem support it, an anonymous file can be used instead: open then immediately delete, use the file descriptor to write. A crash before the end of the write process would release the used storage automatically.
Not a breaking change, only introduce an extra function.