Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add inverse and version to filter cmd #457

Merged
merged 1 commit into from
Jun 22, 2023
Merged

feat: add inverse and version to filter cmd #457

merged 1 commit into from
Jun 22, 2023

Conversation

laurentsenta
Copy link
Contributor

Adds the options --version and --inverse to car filter so that:

echo $REMOVED_CID | car filter --version 1 --inverse ./input.car ./output.car

Removes the CID and outputs a carv1.

Context:

willscott
willscott approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a reasonable extension of filter

@willscott willscott merged commit 499d0c9 into ipld:master Jun 22, 2023
@laurentsenta laurentsenta deleted the feat/filter-with-version-and-inverse branch June 22, 2023 10:23
@laurentsenta laurentsenta mentioned this pull request Jun 22, 2023
Closed
@BigLep BigLep mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

@rvagg rvagg Awaiting requested review from rvagg rvagg is a code owner

@masih masih Awaiting requested review from masih masih is a code owner

@hannahhoward hannahhoward Awaiting requested review from hannahhoward hannahhoward is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentsenta @willscott