deepequal: tests, and treat nils as equal.

ipld · Sep 30, 2021 · 79a0220 · 79a0220
1 parent fdc808c
commit 79a0220
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/datamodel/equal.go b/datamodel/equal.go
@@ -26,7 +26,7 @@ package datamodel
 // It is generally not recommended to call DeepEqual on ADL nodes.
 func DeepEqual(x, y Node) bool {
 	if x == nil || y == nil {
-		return false
+		return x == y
 	}
 	xk, yk := x.Kind(), y.Kind()
 	if xk != yk {

diff --git a/datamodel/equal_test.go b/datamodel/equal_test.go
@@ -40,6 +40,8 @@ var deepEqualTests = []struct {
 	// Repeated basicnode.New invocations might return different pointers.
 	{"SameNodeDiffPointer", basic.NewString("same"), basic.NewString("same"), true},
 
+	{"NilVsNil", nil, nil, true},
+	{"NilVsNull", nil, datamodel.Null, false},
 	{"SameKindNull", datamodel.Null, datamodel.Null, true},
 	{"DiffKindNull", datamodel.Null, datamodel.Absent, false},
 	{"SameKindBool", basic.NewBool(true), basic.NewBool(true), true},