Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use response writer from go-libipni/rwriter #40

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

gammazero
Copy link
Contributor

Replaces code that is common to response writers.

Replaces code that is common to response writers.
@gammazero gammazero requested a review from masih July 18, 2023 02:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (94c0d75) 0.93% compared to head (780cd7b) 1.05%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #40      +/-   ##
========================================
+ Coverage   0.93%   1.05%   +0.11%     
========================================
  Files         10       7       -3     
  Lines        749     665      -84     
========================================
  Hits           7       7              
+ Misses       741     657      -84     
  Partials       1       1              
Impacted Files Coverage Δ
caskadht.go 0.00% <0.00%> (ø)
response_writer_dr.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gammazero gammazero merged commit e965cdd into main Jul 18, 2023
@gammazero gammazero deleted the go-libipni-response-writer branch July 18, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants