Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NoEntries cid gracefully and improve cli output #181

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

masih
Copy link
Member

@masih masih commented Feb 18, 2022

When encountering NoEntries CID, do not attempt to traverse it in
provider CLI.

Do not traverse entries of a removal advertisement even if a CID is
present. Instead, print useufl messages to signal such cases.

Improve output for human readability.

Fixes #179

When encountering `NoEntries` CID, do not attempt to traverse it in
`provider` CLI.

Do not traverse entries of a removal advertisement even if a CID is
present. Instead, print useufl messages to signal such cases.

Improve output for human readability.

Fixes #179
@masih masih requested a review from willscott February 18, 2022 19:10
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #181 (6bef041) into main (9dbb62d) will decrease coverage by 0.88%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   39.96%   39.07%   -0.89%     
==========================================
  Files          44       45       +1     
  Lines        3218     3291      +73     
==========================================
  Hits         1286     1286              
- Misses       1683     1756      +73     
  Partials      249      249              
Impacted Files Coverage Δ
cmd/provider/internal/client.go 0.00% <0.00%> (ø)
cmd/provider/internal/client_store.go 0.00% <0.00%> (ø)
cmd/provider/internal/entries_iter.go 0.00% <0.00%> (ø)
cmd/provider/internal/options.go 0.00% <0.00%> (ø)
cmd/provider/list.go 0.00% <0.00%> (ø)
cmd/provider/verify_ingest.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbb62d...6bef041. Read the comment docs.

@masih masih merged commit b8cd570 into main Feb 18, 2022
@masih masih deleted the masih/cli-list-ad-skip-rm-entries branch February 18, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify / list seems not to work when rm advertisements present
3 participants