Make network announcements optional and introduce engine options #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Feb 28, 2022
Implement the ability to disable network announcements of published advertisements. Change the behaviour of engine, so that announcements are disabled by default until `PublisherKind` is set. Refactor the engine package, and introduce options with defaults such that the barrier to instantiate an engine is low with sensible defaults. Future PRs will refactor the config package to match the options.
masih
force-pushed
the
masih/eng-remote-pub-opts
branch
from
136f7a0 to
022a05e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the ability to disable network announcements of published
advertisements. Change the behaviour of engine, so that announcements
are disabled by default until
PublisherKindis set.Refactor the engine package, and introduce options with defaults such
that the barrier to instantiate an engine is low with sensible defaults.
Future PRs will refactor the config package to match the options.