Upgrade index provider to sti with bindnode schema #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 38.80% 39.42% +0.62%
==========================================
Files 52 52
Lines 3662 3632 -30
==========================================
+ Hits 1421 1432 +11
+ Misses 1973 1932 -41
Partials 268 268
|
masih
force-pushed
the
masih/sti-upgrade-bindnode
branch
3 times, most recently
from
32ac6f5 to
8979e83
Compare
masih
commented
Mar 22, 2022
Reflect changes in storetheindex that replaces IPLD codegen schema with bindnode structs. See: - ipni/storetheindex#268
masih
force-pushed
the
masih/sti-upgrade-bindnode
branch
from
8979e83 to
a20acdd
Compare
gammazero
approved these changes
Mar 22, 2022
| mdBytes, err := md.MarshalBinary() | ||
| if err != nil { | ||
| // Sign the advertisement. | ||
| if err := adv.Sign(e.key); err != nil { |
There was a problem hiding this comment.
nit: err already defined
Suggested change
| if err := adv.Sign(e.key); err != nil { | |
| if err = adv.Sign(e.key); err != nil { |
There was a problem hiding this comment.
I intentionally changed that for tighter scope of err
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect changes in storetheindex that replaces IPLD codegen schema with
bindnode structs.
See: