Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reframe api server #464

Merged
merged 3 commits into from
May 11, 2022
Merged

add reframe api server #464

merged 3 commits into from
May 11, 2022

Conversation

petar
Copy link
Collaborator

@petar petar commented May 9, 2022

Add a Reframe API HTTP server to STI.

Added end-to-end test with a Reframe Client calling FindProviders on the STI HTTP server's Reframe endpoint.

Change is safe to revert.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #464 (cff5416) into main (3a9bc5b) will increase coverage by 0.17%.
The diff coverage is 60.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   45.08%   45.26%   +0.17%     
==========================================
  Files          83       84       +1     
  Lines        6334     6407      +73     
==========================================
+ Hits         2856     2900      +44     
- Misses       3079     3099      +20     
- Partials      399      408       +9     
Impacted Files Coverage Δ
server/finder/test/test.go 51.47% <55.00%> (+0.71%) ⬆️
server/reframe/reframe.go 63.33% <63.33%> (ø)
server/finder/http/server.go 88.88% <100.00%> (+0.65%) ⬆️

@petar petar marked this pull request as ready for review May 9, 2022 19:46
@petar petar mentioned this pull request May 9, 2022
@BigLep BigLep linked an issue May 9, 2022 that may be closed by this pull request
@petar petar requested a review from willscott May 9, 2022 20:06
server/reframe/reframe.go Show resolved Hide resolved
server/reframe/reframe.go Outdated Show resolved Hide resolved
@petar
Copy link
Collaborator Author

petar commented May 11, 2022

@gammazero @willscott Ping to take a look at my responses.

Copy link
Collaborator

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petar petar merged commit 0862f33 into main May 11, 2022
@petar petar deleted the reframe branch May 11, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Reframe protocol server
3 participants