Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2555 Fix Site web.magentatv.de #2564

Merged
merged 2 commits into from
Jan 3, 2025
Merged

#2555 Fix Site web.magentatv.de #2564

merged 2 commits into from
Jan 3, 2025

Conversation

michaelfeinbier
Copy link
Contributor

@michaelfeinbier michaelfeinbier commented Jan 2, 2025 •
edited by freearhey
Loading

The currently used module fetch is not available as node-fetch anymore since Node JS 18. Thus running this site will throw an error

Cannot find module 'node-fetch' from 'sites/web.magentatv.de/web.magentatv.de.config.js'

Closes #2555

This PR removes the dependency for fetch and relies only on axios for fetching the needed cookies and token. I additionally added a change to load this tokens only once which speeds up the fetching a lot (at least on my machine)
I tested on Nodejs 16 and 20

@michaelfeinbier michaelfeinbier mentioned this pull request Jan 2, 2025
Closed
@BellezaEmporium BellezaEmporium merged commit f07514b into iptv-org:master Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BellezaEmporium BellezaEmporium BellezaEmporium approved these changes

@freearhey freearhey freearhey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web.magentatv.de
3 participants
@michaelfeinbier @freearhey @BellezaEmporium