chore(engines): node v22からv20に緩和 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
package.jsonのenginesをnode v22からv20に緩和する。内容
このレポジトリでは、Dependabotでのアップデートを有効にしている。
しかし、Dependabotでは node v20 を使用しており、このレポジトリのnodeバージョン要件に満たないためアップデートに失敗する。
https://github.com/dependabot/dependabot-core/blob/b9ea83bcad97700d007e5e5b57609df0aee756c1/npm_and_yarn/Dockerfile#L15-L33
そこで、解決策として以下2通りを考えた。
.npmrcのengine-strict=trueを消すpackage.jsonのnode指定をnode v20からnode v22に変更する1.の方法ではパッケージマネージャの強制も緩和されてしまうので、2.の方法を採用した。破壊的変更
なし