Skip to content

Commit

Permalink
chore: Use check mark icon for replayed tasks (#298)
Browse files Browse the repository at this point in the history
# Description

This PR implements the following changes:

- [x] Use check mark icon for replayed tasks

The minus icon is a bit unintuitive, and a user can view whether the
task was executed or replayed by expanding the task detail.

## Type of change

- [x] Refactor (non-breaking change that updates existing functionality)

## Test plan (required)

Run the app. See the checkmarks.

## Screenshots/Screencaps

<img width="240" alt="CleanShot 2023-09-06 at 13 42 21@2x"
src="https://github.com/ipvm-wg/homestar/assets/7957636/0a9cdc9f-27b0-40e9-b243-1bc35e626522">
  • Loading branch information
bgins authored Sep 11, 2023
1 parent 888731c commit f388dbf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import CheckCircleIcon from "$components/icons/CheckCircle.svelte";
import ChevronDownIcon from "$components/icons/ChevronDown.svelte";
import ChevronUpIcon from "$components/icons/ChevronUp.svelte";
import MinusCircleIcon from "$components/icons/MinusCircle.svelte";
import XCircleIcon from "$components/icons/XCircle.svelte";
import TaskValue from "$components/controls/TaskValue.svelte";
Expand All @@ -29,9 +28,7 @@
<div class="flex flex-cols gap-2 items-center">
{#if task.status === "waiting"}
<CircleIcon />
{:else if task.status === "replayed"}
<MinusCircleIcon />
{:else if task.status === "executed"}
{:else if task.status === "executed" || task.status === "replayed"}
<CheckCircleIcon />
{:else if task.status === "failure"}
<XCircleIcon />
Expand Down

This file was deleted.

0 comments on commit f388dbf

Please sign in to comment.