-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: go from websocket-server to json rpc websocket/http server #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 71.88% 74.26% +2.37%
==========================================
Files 71 73 +2
Lines 6972 7669 +697
==========================================
+ Hits 5012 5695 +683
- Misses 1960 1974 +14
|
zeeshanlakhani
force-pushed
the
zl/jsonrpc
branch
from
October 31, 2023 19:20
cf2282f
to
adfabc7
Compare
bgins
reviewed
Nov 1, 2023
@zeeshanlakhani @bgins is this the branch I should use to test the JSON RPC for workflows? |
zeeshanlakhani
force-pushed
the
zl/jsonrpc
branch
4 times, most recently
from
November 2, 2023 07:16
68a78ed
to
56eedf0
Compare
zeeshanlakhani
force-pushed
the
zl/jsonrpc
branch
2 times, most recently
from
November 2, 2023 18:37
8d74482
to
6d17195
Compare
Includes: - re-purposing of feature flags * metrics is always a thing (on) * monitoring is the gated feature * websocket-server flag is gone, we only gate push notifications - jsonrpc setup and rpc method register - prometheus exposition format to json parser - Added todo around split networking config Notes: - will not merge this in until example app has been restored with the client changes
zeeshanlakhani
force-pushed
the
zl/jsonrpc
branch
from
November 2, 2023 21:12
f524b11
to
0370da6
Compare
zeeshanlakhani
force-pushed
the
zl/jsonrpc
branch
from
November 3, 2023 14:46
f503663
to
9956ed1
Compare
zeeshanlakhani
force-pushed
the
zl/jsonrpc
branch
from
November 3, 2023 15:16
9956ed1
to
b979a2d
Compare
As discussed, @bgins will move around NotifyReceipt to fit within this notification paradigm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Features & fixes left to add:
Note: network information events will be in a separate PR by @bgins.