-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Toc2] Scrolling: update a mark in TOC to currently displayed section #1057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by processing them in reverse order
[codefolding] fix restoration of nested folds
We use a synchronous method for detecting the live notebook, otherwise we run into various timing issues
since it's only used there anyway
…s of toc2 this is accomplished by defining a window.table_of_contents function synchronously in the first pass of the file, so that it can be called by subsequent scripts in a page.
to cater for malformed exported notebooks
Update yaml files for 5.x compatible nbextensions
Add sound, sticky options to notify plugin
which was still using the old template name
[toc2] use amd structure to avoid polluting the global namespace
Fix codefolding preprocessor configuration
to avoid reloading (from server!) the same config file for each nbextension. In most cases this also means we don't need to require the 'services/config' module any longer.
[collapsible_headings] bugfix for exporter
[toc2] tentative fix for ipython-contrib#1065 -- update jqueryui cdn and version
Add note about native drag&drop support
[various] use Jupyter.notebook.config instance, where appropriate
ok. There are two many conflicts in my attempt to rebase on current master. Closing this PR and opening a new one will save time for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for displaying a small mark at the left of the toc item corresponding to the first header displayed in notebook window. The mark moves as the notebook is scrolled. This was an enhancement request in #944.
![demo_scroll_collapse](https://user-images.githubusercontent.com/7596356/29540207-a3d892fe-86cd-11e7-8476-54c79d9f8d7c.gif)
Two parameters have been added to the configuration: one for enabling this behavior, the second for altering the color of the mark.
Export have been adapted to preserve this scrolling indicator when exporting the notebook to html.
Other modifications include