Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix level test code in plugin collapsible_headings #768

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Fix level test code in plugin collapsible_headings #768

merged 1 commit into from
Oct 18, 2016

Conversation

lll9p
Copy link
Contributor

@lll9p lll9p commented Oct 18, 2016 •
edited
Loading

@jcb91
Copy link
Member

jcb91 commented Oct 18, 2016

although making the level-test code more robust is not a bad idea, it doesn't actually fix the original issue, which lies in code_prettify as mentioned in #767 (comment)

@jcb91 jcb91 mentioned this pull request Oct 18, 2016
Closed
@jcb91
Copy link
Member

jcb91 commented Oct 18, 2016

this seems like a good idea to have in addition to #770, as mentioned there.

@jcb91 jcb91 merged commit e7c0d48 into ipython-contrib:master Oct 18, 2016
@pyup-bot pyup-bot mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lll9p @jcb91