Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to indent comments to current indent level #953

Merged
merged 2 commits into from
Apr 13, 2017
Merged

Add option to indent comments to current indent level #953

merged 2 commits into from
Apr 13, 2017

Conversation

juhasch
Copy link
Member

@juhasch juhasch commented Apr 9, 2017 •
edited
Loading

Add option do enable indenting comments like in jupyter/notebook#954 (comment)
comment_uncomment

jcb91
jcb91 reviewed Apr 9, 2017
View reviewed changes
src/jupyter_contrib_nbextensions/nbextensions/comment-uncomment/readme.md Outdated
Options
-------

indent: add comment at current indent level instead at beginning of line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

instead of at the beginning of the line

?

Might also be worth givin the full name of comment_uncomment_indent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True.

@juhasch juhasch merged commit c983938 into ipython-contrib:master Apr 13, 2017
@juhasch juhasch deleted the feature/comment_indent branch April 13, 2017 21:48
@pyup-bot pyup-bot mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcb91 jcb91 jcb91 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juhasch @jcb91