Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install kernelspec in wheels #223

Merged
merged 9 commits into from
Feb 7, 2017
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 1, 2017

  • wheel kernelspec relies on PATH env to find python, which should be okay when installed to sys.prefix, as opposed to system-wide.
  • can't use universal wheels anymore, since Python version is in kernelspec name and display name

It would be ideal to get a hardcoded path at install time (pypa/pip#4032), but for envs this should do until that becomes possible.

After this, it should be a lot harder for the native kernelspec to not be installed, which would be ideal. Plus, uninstalling ipykernel will also uninstall the kernelspec.

- wheel kernelspec relies on PATH env to find python (this should be okay when installed to sys.prefix)
- can't use universal wheels anymore, since Python version is in kernelspec name and display name
@minrk minrk force-pushed the install-kernelspec branch from 65d8c50 to ec7320e Compare February 1, 2017 14:20
@takluyver
Copy link
Member

I'm not convinced by relying on PATH - that assumes that people always activate a virtualenv rather than launching scripts inside it directly.

@minrk minrk changed the title install kernelspec in wheels [wip] install kernelspec in wheels Feb 2, 2017
@minrk
Copy link
Member Author

minrk commented Feb 2, 2017

We could handle the executable python in jupyter_client to explicitly mean sys.executable (jupyter/jupyter_client#235), which should take care of that.

minrk added 4 commits February 2, 2017 10:50
instead of setup_requires
and skip travis-wheels, which is obsolete now that manylinux wheels are a thing
@minrk minrk force-pushed the install-kernelspec branch from 7a2c55e to f7a116c Compare February 7, 2017 10:15
@minrk minrk changed the title [wip] install kernelspec in wheels install kernelspec in wheels Feb 7, 2017
@minrk minrk merged commit 654c782 into ipython:master Feb 7, 2017
@minrk
Copy link
Member Author

minrk commented Feb 7, 2017

Well, crap. I swear I didn't click the merge button, but GitHub interpreted a click in the comment area as a click of the merge button (not sure if it's GitHub's or my browser's fault). I can revert and re-issue the PR if you want, or we can continue to review this PR and I'll open a new one for any changes that should result.

I cleaned up travis.yml a bit to do a 'regular' install rather than an editable one for testing.

@takluyver
Copy link
Member

Let's carry on without reverting.

@minrk minrk deleted the install-kernelspec branch February 7, 2017 12:42
@minrk minrk added this to the 4.6 milestone Feb 7, 2017
@cben
Copy link

cben commented Jun 2, 2017

Nice!
It seems this installs the kernel.json pip install . but not on pip install -e . (which README.md recommends for developement). EDIT: might be related to pypa/sampleproject#30 and/or pypa/pip#3160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants