Allow do_inspect to return a rich display when enable_html_pager is True
#361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyfast
changed the title
do_inspect returns __text/html__ when enable_html_pager is Truedo_inspect to return a rich display when enable_html_pager is True
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JupyterLab inspector can will accept text/html results. This pull request uses
object_inspect_mimeinstead ofobject_inspect_textto inspect objects.object_inspect_textis already callingobject_inspect_mimeto return plain/text. This new feature optionally removes the text/html result data ifenable_html_pageris False.This also addresses an old issue #51 and inspects the object once.