Use pre-3.10 serialization code on PyPy3.10 #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new serialization code for Python 3.10+ does not seem to work
on PyPy3.10 7.3.13, as it causes:
ValueError: no signature found for builtin type <class 'code'>
Switch back to the old code if PyPy is used, at least for the time
being. With this change, the test suite passes on PyPy3.10.
Fixes ipython#845
|
These failure don't seem related to my changes. |
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new serialization code for Python 3.10+ does not seem to work on PyPy3.10 7.3.13, as it causes:
Switch back to the old code if PyPy is used, at least for the time being. With this change, the test suite passes on PyPy3.10.
Fixes #845