Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename MyClass to School #858

Merged
merged 1 commit into from
Sep 11, 2023
Merged

rename MyClass to School #858

merged 1 commit into from
Sep 11, 2023

Conversation

metaperl
Copy link
Contributor

@metaperl metaperl commented Sep 9, 2023

In the docs and sample code, MyClass is a rather confusing and artificial name. To give the docs and example a more practical flavor, I have renamed MyClass to School in both the docs and the example code.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 merged commit 4915986 into ipython:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants