Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter #667

Conversation

soleinik-figment
Copy link

@soleinik-figment soleinik-figment commented Nov 16, 2022

In brief

This change adds Prometheus metrics exports for observability. Expose session stats counters, such as PreCommits,Proposals, PreVotes in addition to errors StateErrors (all inclusive errors, including DoubleSign ) and DoubleSign (by itself).

What's the usecase?

To pause signing in double signing possibility, to avoid slashing

@tony-iqlusion
Copy link
Member

tony-iqlusion commented Aug 1, 2023

As a general comment, this seems to add quite a bit of code.

I've been looking at https://autometrics.dev/ as a potential alternative. It uses a proc macro-based approach which makes it easy to instrument any function:

https://github.com/autometrics-dev/autometrics-rs/

(It still uses prometheus-client under the hood)

@tony-iqlusion
Copy link
Member

Closing as stale.

It'd be great to have Prometheus support, but IMO this PR is way too low-level and includes a lot of code which https://autometrics.dev/ would abstract away.

@DavidVentura
Copy link

DavidVentura commented Dec 11, 2024

Hey @tony-iqlusion, I want to make a PR using autometrics, however, the crate is no longer maintained.

Do you have an opinion on whether that's fine, or you'd rather use something else?

Alternatively, I'm fairly sure I can make a PR using prometheus with a minimal footprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants