Clean up APDU construction with builder API #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the `APDU` struct into a builder for serialized APDU messages. This makes APDU construction safer and more idiomatic, and also caught a few bugs in the process (missing templ from the C translation).
str4d
reviewed
Nov 21, 2019
| } | ||
| } | ||
|
|
||
| apdu.zeroize(); | ||
| let _ = self._ykpiv_end_transaction(); |
There was a problem hiding this comment.
Now missing the transaction end for the paths that lead here.
There was a problem hiding this comment.
@str4d wouldn't worry too much about these. in my PC/SC PR I'm deleting them all and replacing them with the safe RAII pcsc::Transaction type.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
APDUstruct into a builder for serialized APDU messages.This makes APDU construction safer and more idiomatic, and also caught a few bugs in the process (missing templ from the C translation).