tests: Initial connect test and docs #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this nukes all of the original C source code tests, but these are present both in the source history and in the original project, so I think we'll be OK. |
tarcieri
commented
Nov 25, 2019
| @@ -376,7 +388,7 @@ impl YubiKey { | |||
| /// Change the Personal Identification Number (PIN). | |||
| /// | |||
| /// The default PIN code is 123456 | |||
| pub unsafe fn change_pin(&mut self, current_pin: &[u8], new_pin: &[u8]) -> Result<(), Error> { | |||
| pub fn change_pin(&mut self, current_pin: &[u8], new_pin: &[u8]) -> Result<(), Error> { | |||
There was a problem hiding this comment.
Oops, this is an extraneous change I wanted to do separately, but if nobody cares I think I'll just leave it in here.
Adds an extremely basic initial test to ensure that we are able to connect to a YubiKey. The test is marked `#[ignore]` in the hope that we can eventually start adding tests which run in CI, e.g. against a mock card. This also includes a fix for calculating the APDU size, since the ones we were sending originally were overly long.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extremely basic initial test to ensure that we are able to connect to a YubiKey.
The test is marked
#[ignore]in the hope that we can eventually start adding tests which run in CI, e.g. against a mock card.This also includes a fix for calculating the APDU size, since the ones we were sending originally were overly long.