Create typed structs for PIN-protected and admin metadata #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MgmKey::set_protected and YubiKey::set_pin_last_changed both contained bugs resulting from the conversion of C pointer logic (incorrect buffer management). The new Metadata struct holds its own buffer, avoiding the problem.
str4d
commented
Jan 31, 2021
| assert!(yubikey.authenticate(protected.clone()).is_ok()); | ||
|
|
||
| // Set back to the default management key. | ||
| // TODO: This does not clear the previous key from the protected metadata. |
There was a problem hiding this comment.
Figured I'd leave this test and functionality behind the untested feature flag until we'd decided how to address this. See also #27 (comment).
tony-iqlusion
approved these changes
Jan 31, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MgmKey::set_protectedandYubiKey::set_pin_last_changedboth contained bugs resulting from the conversion of C pointer logic (incorrect buffer management). The newMetadatastruct holds its own buffer, avoiding the problem.Part of #27.