Make YubiKey::open() more robust #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On systems with a physical card-reader, the previous implementation falsely reports "multiple YubiKeys detected!", even if only one YubiKey is connected. This change attempts to actually open each reader as a YubiKey, and only reports "multiple YubiKeys" if it can actually open more than one. Additionally, this change avoids resetting the YubiKeys in case we find more than one.
tony-iqlusion
approved these changes
Aug 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Notebook contains a physical smart card reader, which caused the
YubiKey::open()function to falsely claim that multiple YubiKey are connected (because twoReaders exist: one of them being the empty physical reader, the other being an actual YubiKey).This patch fixes that. I think the change is preferable to the previous code (and it fixes
open()on my machine).However, there is one possible downside (also described in the doc comment):
If two YubiKeys are connected, and one is currently opened (and locked as exclusive), the caller will now receive "the other" YubiKey, with the (somewhat misleading) implication that only one YubiKey is connected to the system. There is no indication that multiple YubiKey are connected, and I can't imagine a reliable way to avoid such a scenario (if there's a card we can't open, I think we also can't find out what kind of card it is).
I assume the new semantics are acceptable (preferable) in most cases. But it might theoretically trip up users who relied on the previous semantics (which I assume happened to work as expected, as long as no non-YubiKey
Readers are connected).