Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burndown list of HSA/ROCR issues for initial milestone #19636

Open
11 tasks
benvanik opened this issue Jan 8, 2025 · 1 comment
Open
11 tasks

Burndown list of HSA/ROCR issues for initial milestone #19636

benvanik opened this issue Jan 8, 2025 · 1 comment
Assignees
Labels
hal/amdgpu Runtime AMDGPU HAL backend

Comments

@benvanik benvanik added the hal/amdgpu Runtime AMDGPU HAL backend label Jan 8, 2025
@benvanik benvanik self-assigned this Jan 8, 2025
@benvanik
Copy link
Collaborator Author

benvanik commented Jan 8, 2025

The current workaround to llvm/llvm-project#119479 is:

diff --git a/lld/ELF/MarkLive.cpp b/lld/ELF/MarkLive.cpp
index b6c22884d917..08d9ecedf2cc 100644
--- a/lld/ELF/MarkLive.cpp
+++ b/lld/ELF/MarkLive.cpp
@@ -221,7 +221,7 @@ template <class ELFT> void MarkLive<ELFT>::run() {
   // Preserve externally-visible symbols if the symbols defined by this
   // file can interpose other ELF file's symbols at runtime.
   for (Symbol *sym : ctx.symtab->getSymbols())
-    if (sym->isExported && sym->partition == partition)
+    if (sym->includeInDynsym(ctx) && sym->partition == partition)
       markSymbol(sym);
 
   // If this isn't the main partition, that's all that we need to preserve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hal/amdgpu Runtime AMDGPU HAL backend
Projects
None yet
Development

No branches or pull requests

1 participant