rocr: Add WaitMultiple to core Signal #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atgutier
force-pushed
the
atgutier/signal-wait-multiple
branch
4 times, most recently
from
8ca5f41 to
f082e76
Compare
atgutier
force-pushed
the
atgutier/signal-wait-multiple
branch
from
f082e76 to
946a5d7
Compare
|
Any comments on this, @dayatsin-amd? |
dayatsin-amd
approved these changes
Dec 18, 2024
Looks good. Sorry for late response. Thank you for patch! |
dayatsin-amd
force-pushed
the
amd-staging
branch
from
ca84f25 to
ec45775
Compare
11 tasks
atgutier
force-pushed
the
atgutier/signal-wait-multiple
branch
2 times, most recently
from
3fe9f13 to
39f4337
Compare
|
Can you re-review @dayatsin-amd when you get a chance? Some of the Async signal logic changed which requires additional changes to this PR that I'd like you to look at. |
dayatsin-amd
requested changes
Jan 21, 2025
atgutier
force-pushed
the
atgutier/signal-wait-multiple
branch
from
39f4337 to
71fb283
Compare
dayatsin-amd
approved these changes
Jan 21, 2025
dayatsin-amd
force-pushed
the
amd-staging
branch
from
ea66d58 to
9971e7b
Compare
|
!verify full |
1 similar comment
|
!verify full |
Replaces WaitAny with WaitMultiple to more closely align with the underlying driver API for waiting on multiple events. WaitMultiple adds a single parameter, wait_on_all, to the WaitAny interface providing a single function for waiting on multiple events when we only need AND and OR semantics for the signal checking logic.
atgutier
force-pushed
the
atgutier/signal-wait-multiple
branch
from
71fb283 to
0faaa5e
Compare
|
All comments regarding versioning should be fixed now. |
dayatsin-amd
approved these changes
Jan 24, 2025
|
!verify full |
1 similar comment
|
!verify full |
|
Submitted to amd-staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces WaitAny with WaitMultiple to more closely align with the underlying driver API for waiting on multiple events.
WaitMultiple adds a single parameter, wait_on_all, to the WaitAny interface providing a single function for waiting on multiple events when we only need AND and OR semantics for the signal checking logic.