[vmvx] Fix sitofp lowering to consider correct type #11489
Merged
+144
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpienaar
force-pushed
the
vmvx
branch
2 times, most recently
from
c2fecab to
90152ce
Compare
jpienaar
changed the title
Previously the storage type and value type were mixed up. Flagged a couple of more spots that seem suspect to check on. Left as follow up here to move these to ArithToVm in mechanical change.
ScottTodd
reviewed
Dec 12, 2022
compiler/src/iree/compiler/Dialect/VM/Conversion/StandardToVM/ConvertStandardToVM.cpp
Show resolved
Hide resolved
ScottTodd
reviewed
Dec 13, 2022
compiler/src/iree/compiler/Dialect/VM/Conversion/StandardToVM/ConvertStandardToVM.cpp
Outdated
Show resolved
Hide resolved
ScottTodd
reviewed
Dec 13, 2022
compiler/src/iree/compiler/Dialect/VM/Conversion/StandardToVM/ConvertStandardToVM.cpp
Outdated
Show resolved
Hide resolved
…ConvertStandardToVM.cpp Co-authored-by: Scott Todd <[email protected]>
ScottTodd
approved these changes
Dec 13, 2022
This was referenced Dec 14, 2022
This was referenced Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the storage type and value type were mixed up. Fix sitofp lowering and document type usage expectations.
Flagged a couple of more spots that seem suspect to check on.
Left as follow up here to move these to ArithToVm in mechanical change.