ukernels: sub-8-bit support, types s16 * u4 -> s32 and s16 * s16 -> s32
#15343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacob
changed the title
s16 * u4 -> s32 and s16 * s16 -> s32
hanhanW
approved these changes
Nov 1, 2023
Comment on lines
+235
to
+238
| case iree_uk_mmt4d_type_s16s16s32: | ||
| return 0; | ||
| case iree_uk_mmt4d_type_s16u4s32: | ||
| return 0; |
There was a problem hiding this comment.
I'm not familiar with these. It looks like it is returning a null function pointer. Should we add a TODO?
There was a problem hiding this comment.
Yes this is returning a null function pointer, which in this context means "We do not have an arm64-optimized code path for this", which the caller will use to fall back to generic code.
ramiro050
pushed a commit
to ramiro050/iree
that referenced
this pull request
Dec 19, 2023
…> s32` (iree-org#15343) `s16 * u4 -> s32` is the main goal in iree-org#15158, and `s16 * s16 -> s32` is seen as a less-optimized but generically useful path to run generic "some non-8-bit quantized matmuls that we don't have super specialized code for" on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s16 * u4 -> s32is the main goal in #15158, ands16 * s16 -> s32is seen as a less-optimized but generically useful path to run generic "some non-8-bit quantized matmuls that we don't have super specialized code for" on.