Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing copypasta in codegen/flow tests that included ABI ops. #16140

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fixing copypasta in codegen/flow tests that included ABI ops. #16140

merged 1 commit into from
Jan 17, 2024

Conversation

benvanik
Copy link
Collaborator

Nothing under these directories should be copied directly from full programs unmodified - tests should only include the minimal IR required to perform the test.

@benvanik
Fixing copypasta in codegen/flow tests that included ABI ops.
b792028 
Nothing under these directories should be copied directly from full
programs unmodified - tests should only include the minimal IR required
to perform the test.
@benvanik benvanik added codegen Shared code generation infrastructure and dialects cleanup 🧹 labels Jan 17, 2024
@benvanik benvanik requested a review from dcaballe as a code owner January 17, 2024 19:09
@benvanik benvanik enabled auto-merge (squash) January 17, 2024 19:13
MaheshRavishankar
MaheshRavishankar approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@MaheshRavishankar MaheshRavishankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! Will keep this in mind for future. Lot of this was me, and I tend to just take the repro I was using and add it as a lit test....

@benvanik benvanik merged commit 390eeb0 into main Jan 17, 2024
64 checks passed
@benvanik benvanik deleted the benvanik-remove-copypasta branch January 17, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshRavishankar MaheshRavishankar MaheshRavishankar approved these changes

@hanhanW hanhanW Awaiting requested review from hanhanW hanhanW is a code owner

@dcaballe dcaballe Awaiting requested review from dcaballe

Assignees
No one assigned
Labels
cleanup 🧹 codegen Shared code generation infrastructure and dialects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benvanik @MaheshRavishankar