Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytype lint check. #17551

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Remove pytype lint check. #17551

merged 4 commits into from
Jun 7, 2024

Conversation

ScottTodd
Copy link
Member

This isn't providing enough value, triggers false positives, and we want to switch to mypy (as a pre-commit check, see #17430).

Could also remove pytype: disable= annotations and related comments.

Could also remove `pytype: disable=` annotations and related comments.
@ScottTodd ScottTodd added infrastructure Relating to build systems, CI, or testing bindings/python Python wrapping IREE's C API cleanup 🧹 labels Jun 3, 2024
@ScottTodd ScottTodd enabled auto-merge (squash) June 7, 2024 21:21
@ScottTodd ScottTodd merged commit 2baf6c3 into iree-org:main Jun 7, 2024
51 checks passed
@ScottTodd ScottTodd deleted the pytype-remove branch June 7, 2024 21:44
LLITCHEV pushed a commit to LLITCHEV/iree that referenced this pull request Jul 30, 2024
This isn't providing enough value, triggers false positives, and we want
to switch to [mypy](https://mypy-lang.org/) (as a pre-commit check, see
iree-org#17430).

Could also remove `pytype: disable=` annotations and related comments.

Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/python Python wrapping IREE's C API cleanup 🧹 infrastructure Relating to build systems, CI, or testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants