Revert "Propagate reshapes through generics with reduction… #18968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
requested review from
hanhanW,
MaheshRavishankar and
ScottTodd
as code owners
IanWood1
force-pushed
the
revert_prop_through_reduction
branch
2 times, most recently
from
caece27 to
ac014c1
Compare
|
Update: this still should be reverted but @Groverkss is going to also work on making the spec more robust for attention |
hanhanW
approved these changes
Oct 31, 2024
IanWood1
changed the title
…ree-org#18857)" This reverts commit 78481a6. Signed-off-by: Ian Wood <[email protected]>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Nov 12, 2024
…g#18968) This reverts commit 8d3faf8. Signed-off-by: Ian Wood <[email protected]>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Nov 14, 2024
…g#18968) This reverts commit 8d3faf8. Signed-off-by: Ian Wood <[email protected]>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Nov 18, 2024
…g#18968) This reverts commit 8d3faf8. Signed-off-by: Ian Wood <[email protected]>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Nov 18, 2024
…g#18968) This reverts commit 8d3faf8. Signed-off-by: Ian Wood <[email protected]>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…#18968) …(iree-org#18857)" This regresses sdxl int8 perf by increasing the dimensionality of `attention` ops which messes with the attention spec. Revert this for now and reland once `CollapseDimensionsPass` can handle attention. This reverts commit 78481a6. Signed-off-by: Ian Wood <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Dec 5, 2024
…g#18968) This reverts commit 8d3faf8. Signed-off-by: Ian Wood <[email protected]>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Dec 5, 2024
…g#18968) This reverts commit 8d3faf8. Signed-off-by: Ian Wood <[email protected]>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Dec 7, 2024
…g#18968) This reverts commit 8d3faf8. Signed-off-by: Ian Wood <[email protected]>
IanWood1
added a commit
that referenced
this pull request
Jan 8, 2025
Reland after fixing sdxl int8 regressions via #19012. Running CI revealed further performance regressions that have pending patches: #19325 and #19326. This reverts commit 8d3faf8. --------- Signed-off-by: Ian Wood <[email protected]>
|
oh oh, this cause quite a big regression in llama_8b_fp16 At this commit (a5c3879) Before this commit (80cbf6b) |
|
I'd suspect that its causing reduction/matmul ops to get expanded but they can't get collapsed because they are dynamic. Do you have the traces and/or dispatch counts for the runs? |
|
I can give you a full repro in the morning |
MaheshRavishankar
added a commit
to MaheshRavishankar/iree
that referenced
this pull request
Jan 9, 2025
…ree-org#18968)" This reverts commit a5c3879.
MaheshRavishankar
added a commit
to MaheshRavishankar/iree
that referenced
this pull request
Jan 9, 2025
…ree-org#18968)" This reverts commit a5c3879. Signed-off-by: MaheshRavishankar <[email protected]>
MaheshRavishankar
added a commit
that referenced
this pull request
Jan 9, 2025
…19647) This reverts commit a5c3879. Seems like there is a regression due to dynamic shapes #18968 (comment) Signed-off-by: MaheshRavishankar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#18857)"
This regresses sdxl int8 perf by increasing the dimensionality of
attentionops which messes with the attention spec. Revert this for now and reland onceCollapseDimensionsPasscan handle attention.This reverts commit 78481a6.