[Codegen] Update translation_info attribute assembly format. NFC. #19107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the custom assembly format from the `DispatchLoweringPassPipelineAttr` so that it can be exposed via python bindings. The new format is: `#iree_codegen.translation_info<pipeline = X ...>` I updated the project files with the following commands: ``` sd -F 'iree_codegen.translation_info<' 'iree_codegen.translation_info<pipeline = ' ./**/*.mlir sd -F 'translation_info = <' 'translation_info = #iree_codegen.translation_info<pipeline = ' ./**/*.mlir ``` Signed-off-by: Jakub Kuderski <[email protected]>
kuhar
requested review from
hanhanW,
MaheshRavishankar,
IanWood1,
antiagainst,
qedawkins,
Groverkss,
benvanik and
ScottTodd
as code owners
MaheshRavishankar
approved these changes
Nov 12, 2024
12 tasks
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
…ee-org#19107) Drop the custom assembly format from the `DispatchLoweringPassPipelineAttr` so that it can be exposed via python bindings. The new format is: `#iree_codegen.translation_info<pipeline = X ...>` I updated the project files with the following commands: ``` sd -F 'iree_codegen.translation_info<' 'iree_codegen.translation_info<pipeline = ' ./**/*.mlir sd -F 'translation_info = <' 'translation_info = #iree_codegen.translation_info<pipeline = ' ./**/*.mlir ```
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…ee-org#19107) Drop the custom assembly format from the `DispatchLoweringPassPipelineAttr` so that it can be exposed via python bindings. The new format is: `#iree_codegen.translation_info<pipeline = X ...>` I updated the project files with the following commands: ``` sd -F 'iree_codegen.translation_info<' 'iree_codegen.translation_info<pipeline = ' ./**/*.mlir sd -F 'translation_info = <' 'translation_info = #iree_codegen.translation_info<pipeline = ' ./**/*.mlir ``` Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the custom assembly format from the
DispatchLoweringPassPipelineAttrso that it can be exposed via python bindings.The new format is:
#iree_codegen.translation_info<pipeline = X ...>I updated the project files with the following commands: