-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Codegen][Tuner] Add pass to link tuning specs #19281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groverkss
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
compiler/src/iree/compiler/Codegen/Common/LinkTuningSpecsPass.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/LinkTuningSpecsPass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Kuderski <[email protected]>
kuhar
force-pushed
the
transform-link
branch
from
November 25, 2024 18:37
60ec086
to
fcca91a
Compare
Signed-off-by: Jakub Kuderski <[email protected]>
kuhar
force-pushed
the
transform-link
branch
from
November 25, 2024 18:38
919a3a3
to
69d2f21
Compare
hanhanW
reviewed
Nov 25, 2024
compiler/src/iree/compiler/Codegen/Common/LinkTuningSpecsPass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Kuderski <[email protected]>
qedawkins
approved these changes
Nov 25, 2024
Signed-off-by: Jakub Kuderski <[email protected]>
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
This pass is meant for combining multiple tuning specs (e.g., a user-provided one and a default one). We expect the input module to have nested sub-modules with named sequences marked with the `iree_codegen.tuning_spec_entrypoint` unit attributes. The pass collects all such tuning specs and introduce a new named sequence that includes all the other tuning spec entry points. The order of inclusion is the same as the in which these nested tuning specs appear in the IR. Issue: iree-org#19214
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
This pass is meant for combining multiple tuning specs (e.g., a user-provided one and a default one). We expect the input module to have nested sub-modules with named sequences marked with the `iree_codegen.tuning_spec_entrypoint` unit attributes. The pass collects all such tuning specs and introduce a new named sequence that includes all the other tuning spec entry points. The order of inclusion is the same as the in which these nested tuning specs appear in the IR. Issue: iree-org#19214 Signed-off-by: Giacomo Serafini <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pass is meant for combining multiple tuning specs (e.g., a user-provided one and a default one).
We expect the input module to have nested sub-modules with named sequences marked with the
iree_codegen.tuning_spec_entrypoint
unit attributes.The pass collects all such tuning specs and introduce a new named sequence that includes all the other tuning spec entry points. The order of inclusion is the same as the in which these nested tuning specs appear in the IR.
Issue: #19214