Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codegen][Tuner] Add pass to link tuning specs #19281

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

kuhar
Copy link
Member

@kuhar kuhar commented Nov 24, 2024

This pass is meant for combining multiple tuning specs (e.g., a user-provided one and a default one).
We expect the input module to have nested sub-modules with named sequences marked with the
iree_codegen.tuning_spec_entrypoint unit attributes.

The pass collects all such tuning specs and introduce a new named sequence that includes all the other tuning spec entry points. The order of inclusion is the same as the in which these nested tuning specs appear in the IR.

Issue: #19214

Copy link
Contributor

@Groverkss Groverkss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jakub Kuderski <[email protected]>
Signed-off-by: Jakub Kuderski <[email protected]>
Signed-off-by: Jakub Kuderski <[email protected]>
@kuhar kuhar enabled auto-merge (squash) November 25, 2024 18:58
@kuhar kuhar merged commit 1a7b51d into iree-org:main Nov 25, 2024
37 checks passed
Groverkss pushed a commit to Groverkss/iree that referenced this pull request Dec 1, 2024
This pass is meant for combining multiple tuning specs (e.g., a
user-provided one and a default one).
We expect the input module to have nested sub-modules with named
sequences marked with the `iree_codegen.tuning_spec_entrypoint` unit
attributes.

The pass collects all such tuning specs and introduce a new named
sequence that includes all the other tuning spec entry points. The order
of inclusion is the same as the in which these nested tuning specs
appear in the IR.

Issue: iree-org#19214
giacs-epic pushed a commit to giacs-epic/iree that referenced this pull request Dec 4, 2024
This pass is meant for combining multiple tuning specs (e.g., a
user-provided one and a default one).
We expect the input module to have nested sub-modules with named
sequences marked with the `iree_codegen.tuning_spec_entrypoint` unit
attributes.

The pass collects all such tuning specs and introduce a new named
sequence that includes all the other tuning spec entry points. The order
of inclusion is the same as the in which these nested tuning specs
appear in the IR.

Issue: iree-org#19214
Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants