[GPU] Disable prefetching for loops with no computation #19695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvedhmeshram
requested review from
MaheshRavishankar,
qedawkins,
kuhar,
Groverkss and
antiagainst
as code owners
nirvedhmeshram
force-pushed
the
prefetch_issue
branch
3 times, most recently
from
b16fbf4 to
c10eb4d
Compare
Signed-off-by: Nirvedh Meshram <[email protected]>
nirvedhmeshram
force-pushed
the
prefetch_issue
branch
from
c10eb4d to
ba3c6e8
Compare
nirvedhmeshram
changed the title
kuhar
approved these changes
Jan 14, 2025
compiler/src/iree/compiler/Codegen/LLVMGPU/Utils/PrefetchSharedMemoryCopy.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Nirvedh Meshram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point in prefetching if you dont have any compute ops in the loop.
Currently attempting this is leading to a bug described in #19612
The proposed solution implemented in this PR is if the loop has no compute ops then bail out.
Fixes : #19612