[hip] Move calls to hipFree and similar to the cleanup thread. #20020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps them off the main thread since they can block for an unexpectedly large amount of time. Signed-off-by: Andrew Woloszyn <[email protected]>
AWoloszyn
requested review from
antiagainst and
nithinsubbiah
as code owners
AWoloszyn
force-pushed
the
off_thread_free
branch
from
70a3012 to
f57eee4
Compare
benvanik
reviewed
Feb 18, 2025
Signed-off-by: Andrew Woloszyn <[email protected]>
AWoloszyn
force-pushed
the
off_thread_free
branch
from
538e327 to
40ba0ba
Compare
benvanik
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps them off the main thread since they can block for an unexpectedly large amount of time.