Create a clang-tidy option for building IREE #9402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an IREE_ENABLE_CLANG_TIDE flag to IREE to start turning on clang-tidy features. Anything that triggers failures is disabled right now. Includes a kokoro agent that runs clang-tidy.
rsuderman
requested review from
benvanik,
GMNGeoffrey and
ScottTodd
as code owners
benvanik
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
LGTM - I think having an informational check is good to start and we can add additional things for compiler and runtime as needed. One tricky thing with making this blocking is that clang-tidy changes quite a bit (way more than clang-format) and ensuring all users have the same versions that support the same checks is tricky. May still be worth it to make blocking depending on how much noise we catch with this even if it means that users must use our bots as a source of truth for the warnings.
build_tools/kokoro/gcp_ubuntu/cmake/linux/x86-clang-tidy/presubmit.cfg.bak
Outdated
Show resolved
Hide resolved
rsuderman
changed the title
jpienaar
pushed a commit
to jpienaar/iree
that referenced
this pull request
Jun 10, 2022
Adds an IREE_ENABLE_CLANG_TIDY flag to IREE to start turning on clang-tidy features. Anything that triggers failures is disabled right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an IREE_ENABLE_CLANG_TIDY flag to IREE to start turning on clang-tidy features.
Anything that triggers failures is disabled right now.