Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Markdown #11

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Add initial support for Markdown #11

merged 1 commit into from
Sep 23, 2021

Conversation

trangntt-016
Copy link
Contributor

Hi @irenejoeunpark ,

I've just added the following features for issue #9 :

  • Modify file handler so that it accepts md (1): I added a few lines of code in your main() and checks if the input file ends with ".md"

  • It parses # to

    and generates a new HTML file in ./dist folder: I created a new MDUtils class which helps to process and generate MD file to HTML. The reason why I created this new file is that I don't want your Main class to have mixed responsibilities (processing both .txt and .md files) which violates SOLID principles. I think this design makes codes easier to read and maintain. Besides, I suggest you break your codes into smaller pieces so that they can be reused. For example, createHTML() can be a separate function so that it can be re-used for both .txt and .md.

  • I've just updated features in your README.md

Please check it out.

Thanks

@irenejoeunpark irenejoeunpark merged commit 5681811 into irenejoeunpark:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants