Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Python 3.8 to the CI Python matrix #11

Closed

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 5, 2019

Now that Python 3.8 has been added in the the setup-python GitHub Action, it should be added to the Python runtime CI matrix.

@gordonwatts
Copy link
Member

Well, shoot. A number of things over took this, so I'm going to have to do some merging back to get this branch working correctly. And see what has changed in 3.8.

@gordonwatts
Copy link
Member

Ok - the 3.8 contains some real changes to how the AST is laid out. So for now I'll leave this here, and I will have to work on this once we get this into ServiceX.

@matthewfeickert
Copy link
Member Author

Ok - the 3.8 contains some real changes to how the AST is laid out. So for now I'll leave this here, and I will have to work on this once we get this into ServiceX.

Sounds good. This isn't needed, as you already merged master in, but to keep things easy to keep track of in the commit graph I'm just going to rebase this off of the main project's master.

@matthewfeickert matthewfeickert force-pushed the ci/add-Python-3.8-to-CI branch 3 times, most recently from 71ca97b to 8af513f Compare December 1, 2019 06:46
Also Python 3.6 as it was missing
@matthewfeickert matthewfeickert force-pushed the ci/add-Python-3.8-to-CI branch from 8af513f to e54b603 Compare December 1, 2019 06:48
@gordonwatts
Copy link
Member

Closing this b.c. it is now very out of date. Due to ast changes, we are going to have to do some real work before moving to 3.8.

@gordonwatts gordonwatts closed this Sep 4, 2020
@matthewfeickert
Copy link
Member Author

Closing this b.c. it is now very out of date. Due to ast changes, we are going to have to do some real work before moving to 3.8.

Sounds good. Good news is that it is a trivial rebase whenever you get there, so I won't delete the branch. :)

@gordonwatts
Copy link
Member

Thanks!!

@matthewfeickert matthewfeickert deleted the ci/add-Python-3.8-to-CI branch March 30, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants