R4R: Add rewards query #1360
Merged
R4R: Add rewards query #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about add querier interfaces in distribution module? You can refer to F1 distribution implementation. |
Will add querier interfaces and refactor all the distribution query API in next version, but the modification is too big for this version. |
|
It seems that this query interface will consume more calculation resources then others. |
Yes, so we'd better to refactor all the query API by adding querier interfaces in modules. |
wukongcheng
previously approved these changes
Mar 18, 2019
wukongcheng
approved these changes
Mar 18, 2019
chengwenxi
requested review from
haifengxi and
wukongcheng
and removed request for
wukongcheng
haifengxi
approved these changes
Mar 18, 2019
This was referenced Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.