Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Add memo to LCD TxContext #1387

Merged
merged 1 commit into from
Apr 3, 2019
Merged

R4R: Add memo to LCD TxContext #1387

merged 1 commit into from
Apr 3, 2019

Conversation

chengwenxi
Copy link
Contributor

@chengwenxi chengwenxi commented Apr 3, 2019 •
edited by haifengxi
Loading

Resolves: #1386

@chengwenxi chengwenxi added client bug Something isn't working labels Apr 3, 2019
@haifengxi haifengxi changed the title R4R: Add memo for lcd R4R: Add memo to LCD TxContext Apr 3, 2019
yangyanqing
yangyanqing approved these changes Apr 3, 2019
View reviewed changes
Copy link

@yangyanqing yangyanqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haifengxi haifengxi merged commit 95576f3 into irisnet:develop Apr 3, 2019
@chengwenxi chengwenxi deleted the memo branch April 9, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haifengxi haifengxi haifengxi approved these changes

@yangyanqing yangyanqing yangyanqing approved these changes

@wukongcheng wukongcheng Awaiting requested review from wukongcheng

@HaoyangLiu HaoyangLiu Awaiting requested review from HaoyangLiu

@zhangyelong zhangyelong Awaiting requested review from zhangyelong

Assignees
No one assigned
Labels
bug Something isn't working client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chengwenxi @yangyanqing @haifengxi