Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates update #39

Merged
merged 19 commits into from
Sep 25, 2024
Merged

templates update #39

merged 19 commits into from
Sep 25, 2024

Conversation

trel
Copy link
Contributor

@trel trel commented Aug 25, 2024

in this pr:

  • external module handling for AVU-to-JSON conversion
  • schemas on data objects
  • recursion walks to the root
  • schema location now 'url', 'irods', or 'local'

known todo:

  • handle exceptions in 'irods' and 'local' schema gathering

Copy link

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far.

Will review the BATs test later.

metadata_templates.py Show resolved Hide resolved
metadata_templates.py Outdated Show resolved Hide resolved
metadata_templates.py Show resolved Hide resolved
metadata_templates.py Show resolved Hide resolved
metadata_templates.py Outdated Show resolved Hide resolved
metadata_templates.py Outdated Show resolved Hide resolved
metadata_templates.py Outdated Show resolved Hide resolved
metadata_templates.py Show resolved Hide resolved
metadata_templates.py Outdated Show resolved Hide resolved
usage.md Show resolved Hide resolved
@trel
Copy link
Contributor Author

trel commented Sep 25, 2024

have added issues for outstanding comments.

merging as is.

@trel trel merged commit 6bd8ae0 into irods-contrib:main Sep 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants