Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absorb libs3 #2138

Closed
4 tasks done
SwooshyCueb opened this issue Oct 4, 2023 · 12 comments
Closed
4 tasks done

Absorb libs3 #2138

SwooshyCueb opened this issue Oct 4, 2023 · 12 comments
Assignees

Comments

@SwooshyCueb
Copy link
Member

SwooshyCueb commented Oct 4, 2023

  • relicense plugin
  • absorb libs3
  • remove libs3 from externals
  • archive libs3 fork

Given that upstream libs3 is no longer maintained, it may be a good idea to absorb the parts we use into the plugin itself, and eliminate the dependency.

Potential hurdle: libs3 is published under LGPLv3

@trel
Copy link
Member

trel commented Oct 5, 2023

This agrees with my initial thoughts... the hurdle is real.

https://opensource.stackexchange.com/a/6701

@SwooshyCueb
Copy link
Member Author

We could relicense the resource plugin as LGPLv3

@trel
Copy link
Member

trel commented Oct 5, 2023

Ah, very true. Probably the way forward.

@SwooshyCueb
Copy link
Member Author

How are we feeling on this? It sure would be nice to be rid of another externals package.

@korydraughn
Copy link
Contributor

If there's no licensing issues, let's do it.

I think the s3 resource plugin is the only project using libs3 so it makes sense to me.

@SwooshyCueb
Copy link
Member Author

As long as we re-license the plugin to LGPLv3, there are no licensing issues

@trel
Copy link
Member

trel commented Nov 26, 2023

I think we can relicense the s3 resource plugin.

We are not aware of any downstream re-packagers of this plugin that we would need to confer/discuss with or inform and dynamically linking / loading this plugin does not cause any burden to the iRODS server itself.

Let's prepare a PR against this issue to see what that looks like.

SwooshyCueb added a commit to SwooshyCueb/irods_resource_plugin_s3 that referenced this issue Nov 30, 2023
alanking pushed a commit that referenced this issue Nov 30, 2023
SwooshyCueb added a commit to SwooshyCueb/irods_resource_plugin_s3 that referenced this issue Dec 14, 2023
SwooshyCueb added a commit to SwooshyCueb/irods-externals that referenced this issue Dec 14, 2023
alanking pushed a commit to irods/externals that referenced this issue Dec 14, 2023
@SwooshyCueb
Copy link
Member Author

Once our libs3 fork has been archived, this issue can be closed

@SwooshyCueb SwooshyCueb self-assigned this Dec 20, 2023
SwooshyCueb added a commit to SwooshyCueb/irods_resource_plugin_s3 that referenced this issue Feb 22, 2024
SwooshyCueb added a commit to SwooshyCueb/irods_resource_plugin_s3 that referenced this issue Feb 22, 2024
@alanking
Copy link
Contributor

https://github.com/irods/libs3 now has 0 open issues. Are we ready to archive?

@trel
Copy link
Member

trel commented Feb 23, 2024

Ooh, I believe we are. Need to add a last commit and point the reader elsewhere at the top of the README...

@trel trel changed the title Investigate absorbing libs3 Absorb libs3 Feb 23, 2024
alanking added a commit to alanking/libs3 that referenced this issue Feb 23, 2024
alanking added a commit to irods/libs3 that referenced this issue Feb 23, 2024
@alanking
Copy link
Contributor

irods/libs3 has now been archived. @SwooshyCueb - Anything left to do for this?

@SwooshyCueb
Copy link
Member Author

Not that I can think of!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants