Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change filenames in test cases. #2207

Closed
2 tasks done
JustinKyleJames opened this issue Jul 9, 2024 · 1 comment
Closed
2 tasks done

Change filenames in test cases. #2207

JustinKyleJames opened this issue Jul 9, 2024 · 1 comment

Comments

@JustinKyleJames
Copy link
Contributor

JustinKyleJames commented Jul 9, 2024

  • 4-3-stable
  • main

There are a lot of test cases where the filename that is created is "f1" or "f2".

In more recent tests I've used the following pattern:

file1 = f'{inspect.currentframe().f_code.co_name}_f1'

Change all the references from f1 and f2 to this. It's an easy search and replace and it provides a little extra debug information.

This will only be done for 4.3 / main branches as the above code only works in Python 3.

@JustinKyleJames JustinKyleJames self-assigned this Jul 9, 2024
JustinKyleJames added a commit to JustinKyleJames/irods_resource_plugin_s3 that referenced this issue Jul 11, 2024
JustinKyleJames added a commit to JustinKyleJames/irods_resource_plugin_s3 that referenced this issue Jul 12, 2024
JustinKyleJames added a commit to JustinKyleJames/irods_resource_plugin_s3 that referenced this issue Jul 12, 2024
@JustinKyleJames
Copy link
Contributor Author

This has been merged into both main and 4-3-stable. It will not be merged into 4-2-stable as this code uses Python 3 specific features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants