Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of self.assertEquals in test breaks tests #2213

Closed
2 tasks done
FifthPotato opened this issue Aug 16, 2024 · 1 comment
Closed
2 tasks done

Use of self.assertEquals in test breaks tests #2213

FifthPotato opened this issue Aug 16, 2024 · 1 comment
Assignees
@FifthPotato
Labels
testing

Comments

@FifthPotato
Copy link
Contributor

FifthPotato commented Aug 16, 2024 •
edited
Loading

  • main
  • 4-3-stable

On ubuntu24.
self.assertEquals should be replaced with self.assertEqual.

irods_resource_plugin_s3/packaging/resource_suite_s3_nocache.py

Line 1605 in 0304827

self.assertEquals(file_count, u'9\n')

@FifthPotato FifthPotato changed the title Use of self.assertEquals in test hook breaks tests Use of self.assertEquals in test breaks tests Aug 16, 2024
FifthPotato added a commit to FifthPotato/irods_resource_plugin_s3 that referenced this issue Aug 22, 2024
@FifthPotato
[irods#2211,irods#2212,irods#2213] Testing fixes
131b222 
Replace all instances of assertEquals with assertEqual
Do not install unittest-xml-reporting==1.14.0
Version-sniff to avoid upgrading pip on Ubuntu 24 and later
alanking pushed a commit that referenced this issue Aug 22, 2024
@FifthPotato @alanking
[#2211,#2212,#2213] Testing fixes
adda59c 
Replace all instances of assertEquals with assertEqual
Do not install unittest-xml-reporting==1.14.0
Version-sniff to avoid upgrading pip on Ubuntu 24 and later
FifthPotato added a commit to FifthPotato/irods_resource_plugin_s3 that referenced this issue Aug 22, 2024
@FifthPotato
[irods#2211,irods#2212,irods#2213] Testing fixes
4c091d4 
Replace all instances of assertEquals with assertEqual
Do not install unittest-xml-reporting==1.14.0
Version-sniff to avoid upgrading pip on Ubuntu 24 and later
alanking pushed a commit that referenced this issue Aug 22, 2024
@FifthPotato @alanking
[#2211,#2212,#2213] Testing fixes
f99acbf 
Replace all instances of assertEquals with assertEqual
Do not install unittest-xml-reporting==1.14.0
Version-sniff to avoid upgrading pip on Ubuntu 24 and later
@alanking
Copy link
Contributor

@FifthPotato - Please checkbox and close. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FifthPotato FifthPotato

Labels
testing
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanking @FifthPotato