Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JWT Auth #12

Closed
c0ze opened this issue Jan 15, 2018 · 3 comments · Fixed by #16
Closed

Support JWT Auth #12

c0ze opened this issue Jan 15, 2018 · 3 comments · Fixed by #16

Comments

@c0ze
Copy link
Contributor

c0ze commented Jan 15, 2018

Now that functions support JWT auth, we need to add this to the UI as well. @kunihiko-t what do you think ?

@kunihiko-t
Copy link

Hi, I think we need JWT support both of route level & service level.

Route Level

We need JWT Key field here.

app

Service Level

Read JWT_KEY env variable when function-ui starts up. and generate JWT for each request to the function server.
Regarding access restrictions to the UI, it's better to do it on another layer( e.g Basic Auth on Nginx)

What do you think?

@c0ze
Copy link
Contributor Author

c0ze commented Jan 16, 2018

Regarding JWT tokens, yes, looks good ! I agree with your points !

Regarding access restrictions to the UI, it's better to do it on another layer( e.g Basic Auth on Nginx)

Arghh yes, never though about this ! This is of course absolutely necessary as well. I'll think about it ! (You can assume this is out of scope of JWT auth) Let's handle this separately !

@kunihiko-t
Copy link

Yeah, I'll work on Route level one for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants