Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jwt_key #14

Merged
merged 5 commits into from
Jan 27, 2018
Merged

add jwt_key #14

merged 5 commits into from
Jan 27, 2018

Conversation

c0ze
Copy link
Contributor

@c0ze c0ze commented Jan 26, 2018

related to #12

@c0ze c0ze requested a review from kunihiko-t January 26, 2018 09:45
@c0ze
Copy link
Contributor Author

c0ze commented Jan 26, 2018

@kunihiko-t I believe this is now ready, would appreciate if you could take a look !

@kunihiko-t
Copy link

kunihiko-t commented Jan 26, 2018

It works fine 👍

What do you think about displaying tokens with the curl command?
Like -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJleHAiOjE1MDgwNTcwNTEsImlhdCI6MTUwODA1MzQ1MX0.3c_xUaleCdHy_fdU9zFB50j3hqwYWgPZ-EkTXV3VWag'

2018-01-27 1 05 06

@c0ze
Copy link
Contributor Author

c0ze commented Jan 27, 2018

yeah that's a good idea !

@c0ze
Copy link
Contributor Author

c0ze commented Jan 27, 2018

@kunihiko-t ok added, can you have another look ? Thanks !

@c0ze c0ze force-pushed the 12-handle-jwt-key branch from d20dc8e to 9c00934 Compare January 27, 2018 06:11
@c0ze
Copy link
Contributor Author

c0ze commented Jan 27, 2018

rebased to master, now builds successfully

Copy link

@kunihiko-t kunihiko-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@c0ze c0ze merged commit 78e1932 into master Jan 27, 2018
@c0ze c0ze deleted the 12-handle-jwt-key branch January 28, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants