Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify "certain" in "advance clock" #478

Open
3 tasks
cwegrzyn opened this issue Jan 20, 2025 · 0 comments · May be fixed by #481
Open
3 tasks

Clarify "certain" in "advance clock" #478

cwegrzyn opened this issue Jan 20, 2025 · 0 comments · May be fixed by #481
Labels
good first issue Good for newcomers polish General polish that doesn't really change behavior but might make things nicer

Comments

@cwegrzyn
Copy link
Collaborator

Certain works correctly (always advancing the clock), but it does this by setting the advancement probability to 100% and rolling for it. This makes it a little confusing/ambiguous-- why roll for something that will definitely happen?

To make this more straightforward, adjust the behavior of "certain" in the following ways:

  • In the "advance a clock" probability selector prompt, indicate that "certain" means "no roll"
  • Don't roll for "certain"
  • Don't add the "will x advance?" oracle result mechanics mode, just include the clock step node
@cwegrzyn cwegrzyn added good first issue Good for newcomers polish General polish that doesn't really change behavior but might make things nicer labels Jan 20, 2025
sgreg added a commit to sgreg/iron-vault that referenced this issue Jan 25, 2025
@sgreg
Clarify clock advance odds
0f3cb41 
If a clocks's advance odds are set to "Certain", i.e. 100%, rolling dice
is skipped now and the clock is instantly advanced, the same way as if
it was set to "no roll". Clarify that there's no advance roll happening
in the prompt as well.

Fixes iron-vault-plugin#478
@sgreg sgreg linked a pull request Jan 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers polish General polish that doesn't really change behavior but might make things nicer
Projects
Iron Vault Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify clock advance odds sgreg/iron-vault
1 participant
@cwegrzyn