faraday 2 support #155
Merged
faraday 2 support #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This similifies our dependencies a bit. Users can still opt to use the excon adapter if they wish.
irphilli
force-pushed
the
chore/faraday-2-support
branch
2 times, most recently
from
283e550 to
b283df8
Compare
- Remove faraday-middleware as most middleware now bundled with faraday - Require Faraday 1.10+ (1.10 adds json middleware used by us)
irphilli
force-pushed
the
chore/faraday-2-support
branch
from
b283df8 to
7dc744f
Compare
|
Code Climate has analyzed commit 7dc744f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 97.5% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in faraday 2.0 support by:
faraday_middleware. Common middleware now bundled with newer versions of Faraday.excon. Users can still choose to use that adapter with options, but we will default tonet_http.