Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to create and update comments on a story. #84

Merged
merged 2 commits into from
Nov 16, 2016

Conversation

samsonasu
Copy link
Contributor

Implements #83

Codebase is a pleasure to work in, thanks again.

@coveralls
Copy link

coveralls commented Nov 16, 2016

Coverage Status

Coverage increased (+0.1%) to 97.209% when pulling 5429021 on samsonasu:bs-create-update-comments into ef88044 on dashofcode:master.

@samsonasu samsonasu force-pushed the bs-create-update-comments branch from 5429021 to 717e3a3 Compare November 16, 2016 14:35
@coveralls
Copy link

coveralls commented Nov 16, 2016

Coverage Status

Coverage increased (+0.1%) to 97.209% when pulling 717e3a3 on samsonasu:bs-create-update-comments into ef88044 on dashofcode:master.

Copy link
Contributor

@forest forest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the one small change.

Thanks for the contribution.

end
end

def create(project_id, story_id, params={})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move create and update into a new Endpoints::Comment class? See Endpoints::Tasks and Endpoints::Task. Just trying to keep the collection and singular resource behavior together and separate.

@samsonasu
Copy link
Contributor Author

Sure thing 👍

@coveralls
Copy link

coveralls commented Nov 16, 2016

Coverage Status

Coverage increased (+0.1%) to 97.224% when pulling d93ca0f on samsonasu:bs-create-update-comments into ef88044 on dashofcode:master.

@forest
Copy link
Contributor

forest commented Nov 16, 2016

👍

@forest forest merged commit 740bdf4 into irphilli:master Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants