-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add story transitions #87
Conversation
# | ||
# @param [Hash] params | ||
# @return [Array[StoryTransition]] | ||
def story_transitions(params = {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be named transitions
so that it is an override of the getter. The getter is implementing a lazy load of the transitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. So the test .json is now generated. But the story that's used doesn't have any transitions:
request:
"request":{
"method":"get",
"uri":"https://www.pivotaltracker.com/services/v5/projects/1027488/stories/66728004/transitions",
...
response:
"response":{
"status":{
"code":200,
"message":null
},
...
Do I need to add a transition to that story, or should I rely on a another story which has transitions?
I'll figure out the tests. Thanks for contributing. |
This will add story transitions end point. Finishes #86
I'm not certain how to get VCR to generate the right .json.