Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add story transitions #87

Closed
wants to merge 3 commits into from
Closed

Add story transitions #87

wants to merge 3 commits into from

Conversation

tir38
Copy link

@tir38 tir38 commented Dec 29, 2016

This will add story transitions end point. Finishes #86

I'm not certain how to get VCR to generate the right .json.

@coveralls
Copy link

coveralls commented Dec 29, 2016

Coverage Status

Coverage decreased (-0.3%) to 96.181% when pulling 6fa5232 on tir38:add_story_transitions into d0b5962 on dashofcode:master.

#
# @param [Hash] params
# @return [Array[StoryTransition]]
def story_transitions(params = {})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be named transitions so that it is an override of the getter. The getter is implementing a lazy load of the transitions.

Copy link
Author

@tir38 tir38 Jan 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. So the test .json is now generated. But the story that's used doesn't have any transitions:

request:

"request":{  
            "method":"get",
        "uri":"https://www.pivotaltracker.com/services/v5/projects/1027488/stories/66728004/transitions",
            ...

response:

"response":{  
            "status":{  
               "code":200,
               "message":null
            },
            ...

Do I need to add a transition to that story, or should I rely on a another story which has transitions?

@coveralls
Copy link

coveralls commented Jan 2, 2017

Coverage Status

Coverage decreased (-0.07%) to 96.371% when pulling bea84d6 on tir38:add_story_transitions into d0b5962 on dashofcode:master.

@forest
Copy link
Contributor

forest commented Jan 2, 2017

I'll figure out the tests. Thanks for contributing.

@forest
Copy link
Contributor

forest commented Jan 3, 2017

@tir38 pulled you code into #90 and got the test passing. Just have to use a story that had some transitions. To do that I had to log into the Tracker project and transition the story. VCR just records the API calls so they have to work for real at least once.

@forest forest closed this Jan 3, 2017
@tir38 tir38 deleted the add_story_transitions branch January 12, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants